Re: [PATCH V2 3/5] Documentation/devicetree/bindings: b850v3_lvds_dp
From: Javier Martinez Canillas <hidden>
Date: 2016-06-10 18:54:45
Also in:
dri-devel, linux-arm-kernel, lkml
Hello Peter, On Thu, Jun 9, 2016 at 12:25 PM, Peter Senna Tschudin [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Devicetree bindings documentation for the GE B850v3 LVDS/DP++ display bridge. Cc: Enric Balletbo i Serra <enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Cc: Philipp Zabel <redacted> Cc: Rob Herring <redacted> Cc: Fabio Estevam <redacted> Signed-off-by: Peter Senna Tschudin <peter.senna-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> --- Changes from V1: - Replaced '_' by '-' in node names or compatible strings - Added missing @73 to the example .../devicetree/bindings/ge/b850v3_lvds_dp.txt | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txtdiff --git a/Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt b/Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt new file mode 100644 index 0000000..46bbea9 --- /dev/null +++ b/Documentation/devicetree/bindings/ge/b850v3_lvds_dp.txt@@ -0,0 +1,38 @@ +Driver for GE B850v3 LVDS/DP++ display bridge + +Required properties: + - compatible : should be "ge,b850v3_lvds_dp".
It seems you forgot to replace '_' by '-' (you did in the example though)
quoted hunk ↗ jump to hunk
+ - reg : should contain the address used to ack the interrupts. + - interrupt-parent : should link to the gpio used as interrupt + source on the host.
Is the interrupt parent always a GPIO controller since that is what this description says. Shouldn't be instead something like instead? interrupt-parent: phandle of the interrupt controller that services interrupts to the device
quoted hunk ↗ jump to hunk
+ - interrupts : one interrupt should be described here, as in + <0 IRQ_TYPE_LEVEL_HIGH>. + - edid-reg : should contain the address used to read edid information + - port : should describe the vide signal connection between the host
s/vide/video
quoted hunk ↗ jump to hunk
+ and the bridge. + +Example: + +&mux2_i2c2 { + status = "okay"; + clock-frequency = <100000>; + + b850v3-lvds-dp-bridge@73 { + compatible = "ge,b850v3-lvds-dp"; + #address-cells = <1>; + #size-cells = <0>; + + reg = <0x73>; + interrupt-parent = <&gpio2>; + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + + edid-reg = <0x72>; + + port@0 { + reg = <0>;
AFAIU a unit-address and reg property for ports are only needed if you have more than one port according to Documentation/devicetree/bindings/graph.txt and Documentation/devicetree/bindings/media/video-interfaces.txt.
quoted hunk ↗ jump to hunk
+ b850v3_dp_bridge_in: endpoint { + remote-endpoint = <&lvds0_out>; + }; + }; + }; +}; --
Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html