Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support

On Thu, 09 Jun 2016, Wadim Egorov wrote:

On 08.06.2016 16:17, Lee Jones wrote:

quoted

On Thu, 02 Jun 2016, Wadim Egorov wrote:

quoted

The RK818 chip is a power management IC for multimedia and handheld

"Power Management IC (PMIC)"

quoted

devices. It contains the following components:

- Regulators
- RTC
- Clkout

Clocking

quoted

- battery support

Battery support

quoted

Both chips RK808 and RK818 are using a similar register map.

"Both RK808 ad RK818 chips"

quoted

So we can reuse the RTC and Clkout functionality.

Swap '.' for ','.

quoted

Signed-off-by: Wadim Egorov <redacted>
---
 drivers/mfd/Kconfig       |   4 +-
 drivers/mfd/rk808.c       | 231 ++++++++++++++++++++++++++++++++++++++--------
 include/linux/mfd/rk808.h | 162 ++++++++++++++++++++++++++++++--
 3 files changed, 350 insertions(+), 47 deletions(-)

[...]

quoted

quoted

-struct rk808_reg_data {
-	int addr;
-	int mask;
-	int value;
-};

Why are you moving this to the header?

It is now part of the rk808 struct.

Why?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog