Re: [v1 PATCH 1/4] Documentation: bindings: add dt doc for Rockchip USB Type-C PHY
From: Rob Herring <robh@kernel.org>
Date: 2016-06-06 14:27:41
Also in:
linux-arm-kernel, linux-rockchip, lkml
On Fri, Jun 03, 2016 at 11:15:08PM +0800, Chris Zhong wrote:
quoted hunk ↗ jump to hunk
This patch adds a binding that describes the Rockchip USB Type-C PHY for rk3399 Signed-off-by: Chris Zhong <redacted> --- Changes in v1: - add extcon node description - move the registers in phy driver - remove the suffix of reset .../devicetree/bindings/phy/phy-rockchip-typec.txt | 46 ++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-typec.txtdiff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt new file mode 100644 index 0000000..964e0f7 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt@@ -0,0 +1,46 @@ +* ROCKCHIP type-c PHY +--------------------- + +Required properties: + - compatible: should be "rockchip,rk3399-typec-phy0" or + "rockchip,rk3399-typec-phy1"
What's the difference between 0 and 1? If it is to handle the register offsets you have in the previous version and the phy blocks are identical, then the compatible strings should be the same.
+ - reg : Address and length of the usb phy control register set + - rockchip,grf : phandle to the syscon managing the "general + register files" + - clocks : phandle + clock specifier for the phy clocks + - clock-names: string, clock name, must be "tcpdcore", "tcpdphy_ref"; + - resets : a list of phandle + reset specifier pairs + - reset-names : string reset name, must be: + "tcphy", "tcphy_pipe", "uphy_tcphy" + - #phy-cells: Must be 0. See ./phy-bindings.txt for details. + - extcon: extcon specifier for the Power Delivery