Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block
From: Hanjun Guo <hidden>
Date: 2016-06-06 08:03:41
Also in:
linux-arm-kernel, lkml
From: Hanjun Guo <hidden>
Date: 2016-06-06 08:03:41
Also in:
linux-arm-kernel, lkml
Hi Leizhen, On 2016/6/6 9:24, Leizhen (ThunderTown) wrote:
On 2016/6/3 17:45, Will Deacon wrote:quoted
On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote:quoted
On 2016/6/2 4:13, Rob Herring wrote:quoted
I believe you still need this and not the one above. You only need it within the loop if you return. Otherwise, the last node always need to be put.OK. Thanks. Addition with Matthias's suggestion, I will move "return" into this patch, so that this of_node_put(np) can be safely removed.Do you want to include Kefeng's [1] patches in your series too? We don't need two sets of related NUMA cleanups :)Yes, It's originally suggested by Joe Perches.
I think Will suggested us to add Kefeng's NUMA cleanup patches into yours and send a new version, just see comments from Will, > Actually, I see you've already respun the series, do don't worry about > doing another version just for this. Will, correct me if I'm wrong. Thanks Hanjun