RE: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

Hi Tony,

I can submit a V2 version about the "disabled", or just drop this patch?

Thanks,
Yong
-----Original Message-----
From: Tony Lindgren [mailto:tony@atomide.com] 
Sent: Friday, June 3, 2016 1:57 AM
To: Robert Nelson <redacted>
Cc: Li, Yong B <redacted>; Benoit Cousson <redacted>; Rob Herring <robh+dt@kernel.org>; Pawel Moll <redacted>; Mark Rutland <mark.rutland@arm.com>; Ian Campbell <redacted>; Kumar Gala <redacted>; Russell King <redacted>; linux-omap@vger.kernel.org; devicetree <redacted>; linux-arm-kernel@lists.infradead.org; linux kernel <redacted>; sdliyong@gmail.com
Subject: Re: [PATCH] ARM: dts: am335x-boneblack: add i2c1 DT entry

* Robert Nelson [off-list ref] [160602 10:48]:

On Thu, Jun 2, 2016 at 12:39 PM, Tony Lindgren [off-list ref] wrote:

quoted

* Robert Nelson [off-list ref] [160602 10:39]:

quoted

On Thu, Jun 2, 2016 at 2:41 AM, Yong Li [off-list ref] wrote:

quoted

From: Yong Li <redacted>

Without this patch, I2C-1 is missing on beaglebone black boards

Signed-off-by: Yong Li <redacted>
---
 arch/arm/boot/dts/am335x-boneblack.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

This is also 'common' for the white/green, if your really going to 
push this, please add it to:

am335x-bone-common.dtsi

But isn't this exposed on the cape pins? So the use can be whatever 
for these pins?

That is correct, "i2c1" is on the cape connector, with no primary 
function defined.

Currently on mainline, the board and cape eeprom i2c bus's are enabled.

i2c0 = board eeprom
i2c2 = 'cape' eeprom

personally, nak by me to add i2c1 by default, should use overlay's to enable it.

Yes sounds like the best we can do is define it but set it with status = "disabled" for now.

Regards,

Tony