Re: [PATCH v2 3/5] ARM: dts: Add I2C1 support for STM32F429 SoC
From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Date: 2016-06-02 16:19:29
Also in:
linux-arm-kernel, linux-i2c, lkml
2016-06-02 16:26 GMT+02:00 M'boumba Cedric Madianga [off-list ref]:
quoted hunk ↗ jump to hunk
Signed-off-by: Patrice Chotard <redacted> Signed-off-by: M'boumba Cedric Madianga <redacted> --- arch/arm/boot/dts/stm32f429.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi index 434d4b9..d5857eb 100644 --- a/arch/arm/boot/dts/stm32f429.dtsi +++ b/arch/arm/boot/dts/stm32f429.dtsi@@ -323,6 +323,18 @@ slew-rate = <2>; }; }; + + i2c1_sda_pin: i2c1_sda@0 { + pins { + pinmux = <STM32F429_PB9_FUNC_I2C1_SDA>; + drive-open-drain; + }; + }; + i2c1_scl_pin: i2c1_scl@0 { + pins { + pinmux = <STM32F429_PB6_FUNC_I2C1_SCL>; + }; + }; };
Shouldn't be preferrable to group the two functions in a single one,
as done for usart config in this file?:
usart1_pins_a: usart1@0 {
pins1 {
pinmux = <STM32F429_PA9_FUNC_USART1_TX>;
bias-disable;
drive-push-pull;
slew-rate = <0>;
};
pins2 {
pinmux = <STM32F429_PA10_FUNC_USART1_RX>;
bias-disable;
};
};
Also, I would prefer the phandle to be suffixed with the port number,
as multiple muxing options are available, for example "i2c1_pins_b".
Thanks,
Maxime