Re: [PATCH v4 2/7] media: s5p-mfc: use generic reserved memory bindings
From: Javier Martinez Canillas <hidden>
Date: 2016-05-25 15:18:59
Also in:
linux-media, linux-samsung-soc
Hello Marek, On 05/24/2016 09:31 AM, Marek Szyprowski wrote:
quoted hunk ↗ jump to hunk
Use generic reserved memory bindings and mark old, custom properties as obsoleted. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- .../devicetree/bindings/media/s5p-mfc.txt | 39 +++++++++++++++++----- 1 file changed, 31 insertions(+), 8 deletions(-)diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt index 2d5787e..92c94f5 100644 --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt@@ -21,15 +21,18 @@ Required properties: - clock-names : from common clock binding: must contain "mfc", corresponding to entry in the clocks property. - - samsung,mfc-r : Base address of the first memory bank used by MFC - for DMA contiguous memory allocation and its size. - - - samsung,mfc-l : Base address of the second memory bank used by MFC - for DMA contiguous memory allocation and its size. - Optional properties: - power-domains : power-domain property defined with a phandle to respective power domain. + - memory-region : from reserved memory binding: phandles to two reserved + memory regions, first is for "left" mfc memory bus interfaces, + second if for the "right" mfc memory bus, used when no SYSMMU + support is available + +Obsolete properties: + - samsung,mfc-r, samsung,mfc-l : support removed, please use memory-region + property instead +
I wonder if we should maintain backward compatibility for this driver since s5p-mfc memory allocation won't work with an old FDT if support for the old properties are removed. Although I'm not a big fan of keeping backward compatibility just to add dead code that will never be used and I don't know of any Exynos machine where the DTB and kernel are not updated together so I agree with this patch: Reviewed-by: Javier Martinez Canillas <redacted> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America