Thread (6 messages) 6 messages, 4 authors, 2016-05-20

RE: [PATCH V4 6/7] iommu/msm: Use writel_relaxed and add a barrier

From: Sricharan <hidden>
Date: 2016-05-20 11:18:26
Also in: linux-arm-kernel, linux-arm-msm, linux-iommu

Hi Arnd,
quoted
If you need the barrier after the write, it probably was already faulty
before, because writel only implies a barrier before the store, not
after. Of course all the barriers likely made the whole process so
slow that you never hit that race in the end.
ya, it could have worked in this way and i never saw a race issue before this.
The only reason for changing this was to optimise out the additonal barriers
that were happening. I do not see any issue now as well, only that the writes would
be faster.
 I reposted a patch here [1] with comments, i had to delete the
old accessors though as it became unused now.

http://www.spinics.net/lists/arm-kernel/msg505448.html

Regards,
 Sricharan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help