Re: [PATCH v3 5/5] ARM: dts: axp209: Enable usb_power_supply by default

Hi Hans,

On 05/05/2016 12:39 PM, Hans de Goede wrote:

Hi,

On 05-05-16 12:35, Michael Haas wrote:

quoted

This node should be enabled by default. A device is likely to have an
USB power
connection. If USB power is indeed absent, the USB power driver
will simply report the power input as offline.

Nack, as Maxime already said we do not want to enable any optional
features by default. Many top set boxes do not use the usb power supply,
and we don't want some userspace power control panel applet showing
the supply as offline, we want the supply to simply not be there.

it was my understanding that Maxime [0] and ChenYu [1] indicated they
would prefer it to be enabled globally.

Best,

Michael

[0] https://groups.google.com/d/msg/linux-sunxi/cHAlhoIw74g/CbBeoX23AAAJ
[1] https://groups.google.com/d/msg/linux-sunxi/Ee7i8DVI4F8/0b0TBrRkAAAJ

quoted

Signed-off-by: Michael Haas <redacted>
---
 arch/arm/boot/dts/axp209.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/axp209.dtsi

b/arch/arm/boot/dts/axp209.dtsi
index 7deb7d9..4f16be0 100644

--- a/arch/arm/boot/dts/axp209.dtsi
+++ b/arch/arm/boot/dts/axp209.dtsi

@@ -97,7 +97,7 @@

     usb_power_supply: usb_power_supply {
         compatible = "x-powers,axp202-usb-power-supply";
-        status = "disabled";
+        status = "okay";
     };

 };