Thread (21 messages) 21 messages, 6 authors, 2016-12-01

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

From: Hongzhou Yang <hidden>
Date: 2016-05-12 02:55:35
Also in: linux-arm-kernel, linux-gpio, linux-mediatek, lkml

On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote:
On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote:
quoted
Hi,

On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote:
quoted
On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote:
quoted
On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun
[off-list ref] wrote:
quoted
the default mode of GPIO16 pin is gpio, when set EINT16 to
IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be
fixed when set its default mode as usb iddig.

Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Chunfeng, GPIO16 can be used as EINT16 mode, but the pinmux should be 0.
If you want to set its default mode to iddig, you should set it in dts.
I set it in DTS, but it didn't work, because when usb driver requested
IRQ, pinmux was switched back to default mode set by
MTK_EINT_FUNCTION().
After confirmed, there are something wrong with data sheet and pinmux
table, and GPIO16 can only receive interrupt by mode 1. So

Acked-by: Hongzhou Yang <hongzhou.yang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Linus,

We find there are some other pins still have the same problem, so please
hold on it. Sorry for so much noise.

Thanks,
Hongzhou

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help