RE: [v7, 0/5] Fix eSDHC host version register bug

Hi Leo and Scott,

-----Original Message-----
From: Ulf Hansson [mailto:<redacted>]
Sent: Wednesday, April 06, 2016 4:15 PM
To: Yangbo Lu; Scott Wood
Cc: <redacted>; <redacted>;
linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-
clk@vger.kernel.org; linux-i2c@vger.kernel.org; iommu@lists.linux-
foundation.org; netdev@vger.kernel.org; linux-mmc; Rob Herring; Russell
King; Jochen Friedrich; Joerg Roedel; Claudiu Manoil; Bhupesh Sharma;
Zhao Qiang; Kumar Gala; Santosh Shilimkar; Yang-Leo Li; Xiaobo Xie
Subject: Re: [v7, 0/5] Fix eSDHC host version register bug

quoted

quoted

I was about to queue this for next, when I noticed that checkpatch is
complaining/warning lots about these patches. Can you please a round
of checkpatch and fix what makes sense.

Kind regards
Uffe

[Lu Yangbo-B47093] Sorry about this, Uffe...

No worries!

quoted

Should I ignore the warnings that update MAINTAINERS?

drivers/soc/fsl/guts.c isn't part of the MAINTAINERS file, it should be.

I also realize that the FREESCALE QUICC ENGINE LIBRARY section
drivers/soc/fsl/qe/* also need an active maintainer, as it's currently
orphan.

Perhaps we should have create a new section for drivers/soc/fsl/* instead
that covers all of the above? Maybe you or Scott are interested to pick
it up?

I also noted that, "include/linux/fsl/" isn't present in MAINTAINERS,
please add that as well.

[Lu Yangbo-B47093] Could give some advice on the MAINTAINERS for these 'fsl' files
since I really don’t know who should be the right person?
I will appreciate that!

Thanks a lot.

quoted

Regarding the 'undocumented' warning, I will added a patch updates doc

before all the patches, Ok?

Yes, good!

quoted

Thanks a lot :)

Kind regards
Uffe

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu