Re: [PATCH V2 3/4] ARM: dts: imx6ul: Add GPMI nand controller support
From: Lothar Waßmann <hidden>
Date: 2016-03-21 09:47:18
Also in:
linux-arm-kernel
Hi, On Sun, 20 Mar 2016 09:44:19 +0100 Michael Trimarchi wrote:
Hi Lothar On Mon, Feb 22, 2016 at 9:26 AM, Lothar Waßmann [off-list ref] wrote:quoted
Hi, On Sun, 21 Feb 2016 12:29:53 +0100 Michael Trimarchi wrote:quoted
Add support for GPMI nand controller. Signed-off-by: Michael Trimarchi <michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> --- Changes V2: - drop special IMXUL type because seems that is compatible with IMX6Q arch/arm/boot/dts/imx6ul.dtsi | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index f4daf97..1a486ac 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot/dts/imx6ul.dtsi@@ -142,6 +142,39 @@ reg = <0x00900000 0x20000>; }; + dma_apbh: dma-apbh@01804000 { + compatible = "fsl,imx6ul-dma-apbh", "fsl,imx28-dma-apbh"; + reg = <0x01804000 0x2000>; + interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "gpmi0", "gpmi1", "gpmi2", "gpmi3"; + #dma-cells = <1>; + dma-channels = <4>; + clocks = <&clks IMX6UL_CLK_APBHDMA>; + }; + + gpmi: gpmi-nand@01806000 { + compatible = "fsl,imx6q-gpmi-nand";You should still add an imx6ul specific compatible (likewise to the dma_apbh).I understand your point but this seems that imx6q and imx6sx are defined in the same way
That doesn't mean they are correct. I got the same comment from Lucas Stach in [off-list ref] Lothar Waßmann -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html