Re: [PATCH 3/5] ARM: dts: sunxi: Add the SPDIF to the A10 and A20

On 13 March 2016 at 22:50, Maxime Ripard
[off-list ref] wrote:

Hi,

On Sat, Feb 27, 2016 at 05:18:27PM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:

quoted

From: Marcus Cooper <redacted>

Add the SPDIF transceiver controller and clock to the A10 and
A20 dtsi.

Signed-off-by: Marcus Cooper <redacted>
---
 arch/arm/boot/dts/sun4i-a10.dtsi | 23 +++++++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20.dtsi | 23 +++++++++++++++++++++++
 2 files changed, 46 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 0483640..83d46b2 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi

@@ -477,6 +477,17 @@
                      clock-output-names = "ir1";
              };

+             spdif_clk: clk@01c200c0 {
+                     #clock-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-mod1-clk";
+                     reg = <0x01c200c0 0x4>;
+                     clocks = <&pll2 SUN4I_A10_PLL2_8X>,
+                              <&pll2 SUN4I_A10_PLL2_4X>,
+                              <&pll2 SUN4I_A10_PLL2_2X>,
+                              <&pll2 SUN4I_A10_PLL2_1X>;
+                     clock-output-names = "spdif";
+             };
+
              usb_clk: clk@01c200cc {
                      #clock-cells = <1>;
                      #reset-cells = <1>;

@@ -1055,6 +1066,18 @@
                      status = "disabled";
              };

+             spdif: spdif@01c21000 {
+                     #sound-dai-cells = <0>;
+                     compatible = "allwinner,sun4i-a10-spdif";
+                     reg = <0x01c21000 0x40>;

It only takes 64 bytes?

Yep(just like the audio codec!)
http://linux-sunxi.org/SPDIF#SUNXI_SPDIF_DEFAULT_VALUES

quoted

+                     interrupts = <13>;
+                     clocks = <&apb0_gates 1>, <&spdif_clk>;
+                     clock-names = "apb", "spdif";
+                     dmas = <&dma 0 2>, <&dma 0 2>;

Please use the defines here.

ACK...will resend.
Thanks,
CK

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com