Thread (2 messages) flat view 2 messages, 2 authors, 2016-03-11

Re: [PATCH v3 3/3] crypto: add basic driver for the MXC SCC

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2016-03-11 13:16:40
Also in: linux-arm-kernel, linux-crypto

On Mon, Mar 07, 2016 at 01:00:05PM +0100, Steffen Trumtrar wrote:
+	if (ctx->ctrl & SCC_SCM_CTRL_CBC_MODE && req->info)
+		memcpy(scc->base + SCC_SCM_INIT_VECTOR_0, req->info,
+		       scc->block_size_bytes);
Please ensure that the IV is copied back on exit.  I know many
other drivers currently also don't do this but I'm trying to fix
this so I'd rather not add more work for myself down the track :)

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help