Thread (28 messages) 28 messages, 4 authors, 2016-04-12

Re: [PATCH v4 1/8] arm64: dts: rockchip: Clean up /memory nodes

From: Heiko Stuebner <hidden>
Date: 2016-03-31 20:46:33
Also in: linux-arm-kernel, linux-rockchip, lkml

Am Donnerstag, 31. März 2016, 19:15:43 schrieb Heiko Stuebner:
Am Samstag, 19. März 2016, 09:04:08 schrieb Heiko Stuebner:
quoted
Am Mittwoch, 16. März 2016, 14:58:39 schrieb Andreas Färber:
quoted
A dtc update results in warnings for nodes with reg property but
without
unit address in the node name, so rename /memory to /memory@0.

Signed-off-by: Andreas Färber <redacted>
applied to a dts64-fixes branch for 4.6, after changing the commit
message to ----
A dtc update results in warnings for nodes with reg property but without
unit address in the node name, so rename /memory to /memory@startaddress
(memory starts at 0 in the case of the rk3368).
----

To clarify that the @0 is not arbitary chosen.
This dtc update in question hasn't landed in v4.6-rc1 and from what I
gathered will need some changes. The patch is obviously still correct, but
I have now moved it from v4.6-fixes to the regular v4.7 64bit dts
changes.
also it seems "memory" is special and memory without unitname will stay 
allowed [0], especially as uboot or other bootloaders may expect such a node 
to insert the actual amount of memory into it.

Looking at uboot, fdt_fixup_memory_banks seems to look explicitly for a 
"memory" node, so I'm actually not sure, if this is safe to keep at all.


[0] http://www.spinics.net/lists/arm-kernel/msg494038.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help