On 03/25/2016 12:22 PM, Sergei Shtylyov wrote:

On 03/25/2016 02:51 AM, David Lechner wrote:

quoted

+/* register offsets */
+#define CFGCHIP_REG(n)                (n * 4)
+#define CFGCHIP0_REG                CFGCHIP_REG(0)
+#define CFGCHIP1_REG                CFGCHIP_REG(1)
+#define CFGCHIP2_REG                CFGCHIP_REG(2)
+#define CFGCHIP3_REG                CFGCHIP_REG(3)
+#define CFGCHIP4_REG                CFGCHIP_REG(4)

    Why not just use CFGCHIP_REG(n) directly?

I considered that, but I went this way because A) the TRM uses, for 
example, "CFGCHIP2", so I wanted to keep "CFGCHIP" and "2" together and 
B) this tells you how many CFGCHIP registers there are, i.e. there is no 
CFGCHIP5_REG.

quoted

@@ -53,7 +31,6 @@ struct    da8xx_ohci_root_hub {
      /* Time from power on to power good (in 2 ms units) */
      u8    potpgt;
  };
-

    Why?

Unintentional. Must have sneaked in through rebasing or something.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html