On Fri, Mar 18, 2016 at 3:43 AM, Andy Yan [off-list ref] wrote:

Hi Rob:


On 2016年03月17日 23:52, Rob Herring wrote:

quoted

On Tue, Mar 08, 2016 at 08:23:05PM +0800, Andy Yan wrote:

quoted

add device tree bindings document for reboot-mode driver

Signed-off-by: Andy Yan <redacted>

[...]

quoted

quoted

+Required properties:
+- compatible: should be "syscon-reboot-mode"
+- offset: offset in the register map for the storage register (in bytes)
+
+Optional properity:
+- mask: the mask bits of the mode magic value, default set to 0xffffffff
if missing.

I can't see how this is used. I would drop it for now.

With that change:

Acked-by: Rob Herring <redacted>

The mask is suggested by Moritz Fischer in V2[0]. And I found Tegra did
indeed only use some bits of one register to store the reboot mode[1].

And the other bits in the register need to be preserved? Please make
it clear the mask is for the register, not the magic value.

There's also a typo with "properity".

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html