Thread (4 messages) 4 messages, 3 authors, 2016-03-09

Re: [PATCH v2] ARM: dts: add "simple-bus" where "arm,amba-bus" is used alone

From: Masahiro Yamada <hidden>
Date: 2016-03-09 04:32:32
Also in: linux-arm-kernel, linux-arm-msm, linux-rockchip, linux-samsung-soc, lkml

Hi Rob,


2016-03-08 17:49 GMT+09:00 Rob Herring [off-list ref]:
On Mon, Mar 7, 2016 at 11:46 PM, Masahiro Yamada
[off-list ref] wrote:
quoted
The compatible string "simple-bus" is well defined in ePAPR, while
I see no documentation for the "arm,amba-bus" in ePAPR or under
Documentation/devicetree/.

DT is also used by other projects than Linux kernel.  It is not a
good idea to rely on such an unofficial binding.

Signed-off-by: Masahiro Yamada <redacted>
---

Changes in v2:
  - Rephrase the git-log
[...]
quoted
diff --git a/arch/arm/boot/dts/axm55xx.dtsi b/arch/arm/boot/dts/axm55xx.dtsi
index ea288f0..8da4582 100644
--- a/arch/arm/boot/dts/axm55xx.dtsi
+++ b/arch/arm/boot/dts/axm55xx.dtsi
@@ -107,7 +107,7 @@
                };

                amba {
-                       compatible = "arm,amba-bus";
+                       compatible = "arm,amba-bus", "simple-bus";
As I mentioned in the last version, I think you should remove
arm,amba-bus and just have simple-bus. I don't believe anything relies
on having arm,amba-bus.
Sorry about this.

V3 is here now:
https://patchwork.kernel.org/patch/8542031/




-- 
Best Regards
Masahiro Yamada
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help