Re: [PATCH 1/3] of: mtd: add helper reading "nand-ecc-algo" from DT

On Fri, 26 Feb 2016 22:24:21 +0100
Rafał Miłecki [off-list ref] wrote:

On 26 February 2016 at 17:55, Boris Brezillon
[off-list ref] wrote:

quoted

On Fri, 26 Feb 2016 17:30:47 +0100
Rafał Miłecki [off-list ref] wrote:

quoted

What about:
1) Adding new nand-ecc-algo as this patch does
2) Deprecating "soft_bch" value from nand-ecc-mode property

Sounds good to me.

I have problems understanding "soft" values which maps to the
NAND_ECC_SOFT. What exactly algorithm is that? It uses functions from
drivers/mtd/nand/nand_ecc.c but this file isn't really helpful. I was
only able to find "3-byte ECC" phase. Kconfig config MTD_NAND_ECC also
doesn't have any description. I also tried looking at
Documentation/mtd/nand_ecc.txt but still no luck.

Does this algorithm has any name?

AFAIR, nand_ecc.c is implementing Hamming ECC.

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html