Thread (8 messages) 8 messages, 3 authors, 2016-02-24

Re: [PATCH v2 1/2] clk: add lpc18xx creg clk driver

From: Michael Turquette <mturquette@baylibre.com>
Date: 2016-02-24 21:05:53
Also in: linux-clk

Quoting Joachim Eastwood (2016-02-20 10:53:36)
+static const struct clk_ops clk_creg_32k = {
+       .enable         = clk_creg_enable,
+       .disable        = clk_creg_disable,
There should be a .is_enabled here.
+       .prepare        = clk_creg_32k_prepare,
+       .unprepare      = clk_creg_32k_unprepare,
+       .is_prepared    = clk_creg_32k_is_prepared,
+};
+
+static const struct clk_ops clk_creg_1k = {
+       .enable         = clk_creg_enable,
+       .disable        = clk_creg_disable,
Ditto.

Otherwise patch looks good to me. Thanks a lot for all of the rework.

Regards,
Mike
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help