Thread (18 messages) 18 messages, 3 authors, 2016-03-15

Re: [PATCH 2/4] tools: gpio: Add necessary include paths

From: Markus Pargmann <hidden>
Date: 2016-02-24 06:39:33
Also in: linux-gpio

On Tuesday, February 23, 2016 02:26:09 PM Linus Walleij wrote:
On Tue, Feb 23, 2016 at 8:54 AM, Markus Pargmann [off-list ref] wrote:
quoted
Add include paths to the Makefile so that linux/gpio.h can be found even
on systems without this header.

Signed-off-by: Markus Pargmann <redacted>
(...)
quoted
-CFLAGS += -Wall -g -D_GNU_SOURCE
+CFLAGS += -Wall -g -D_GNU_SOURCE -I ../include -I ../../include/uapi
This is probably not how userspace compilation is supposed
to work. The way I understand it, userspace programs from tools/*
should be compiled like this:

make headers_install ARCH=foo INSTALL_HDR_PATH=<bar>
cd tools/gpio
make CFLAGS="$CFLAGS -I<bar>"

The reason being that UAPI files can differ after install depending
on arch.
I see, thanks for explaining.

Best Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help