Re: [PATCH 1/3] clk: unconditionally recurse into clk/mvebu/
From: Marcin Wojtas <hidden>
Date: 2016-02-15 08:33:26
Also in:
linux-arm-kernel, linux-clk
Hi Thomas, 2016-02-15 8:34 GMT+01:00 Thomas Petazzoni [off-list ref]:
quoted hunk
The drivers/clk/mvebu directory is only being built when CONFIG_PLAT_ORION=y. As we are going to support additional mvebu platforms in drivers/clk/mvebu, which don't have CONFIG_PLAT_ORION=y, we need to recurse into this directory regardless of the value of CONFIG_PLAT_ORION. Since all files in drivers/clk/mvebu/ are already conditionally compiled depending on various Kconfig options, we can recurse unconditionally into drivers/clk/mvebu without any other change. Signed-off-by: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> --- drivers/clk/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index b038e36..e08bb0e 100644 --- a/drivers/clk/Makefile +++ b/drivers/clk/Makefile@@ -61,7 +61,7 @@ obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/ ifeq ($(CONFIG_COMMON_CLK), y) obj-$(CONFIG_ARCH_MMP) += mmp/ endif -obj-$(CONFIG_PLAT_ORION) += mvebu/ +obj-y += mvebu/
I know it works with obj-y, but how about using obj-$(CONFIG_ARCH_MVEBU)? A person editing this Kconfig in future wouldn't have to run git blame in order to ensure with your commit log, that he doesn't compile anything more than planned. Best regards, Marcin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html