Re: [PATCH] ARM: dts: rockchip: replace gpio-key, wakeup with wakeup-source property
From: Heiko Stuebner <hidden>
Date: 2016-02-09 23:32:51
Also in:
linux-arm-kernel, linux-rockchip
Hi Sudeep, Am Montag, 8. Februar 2016, 21:55:12 schrieb Sudeep Holla:
Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source. Few dts files assign value "1" to gpio-key,wakeup and in one instance a value "0" is assigned probably assuming it won't be enabled as a wakeup source. Since the presence of the boolean property indicates it is enabled, value of "0" have no value. This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property which inturn fixes the above mentioned issue. Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Reviewed-by: Heiko Stuebner <redacted> Signed-off-by: Sudeep Holla <redacted> --- arch/arm/boot/dts/rk3066a-bqcurie2.dts | 3 +-- arch/arm/boot/dts/rk3066a-rayeager.dts | 2 +- arch/arm/boot/dts/rk3188-radxarock.dts | 2 +- arch/arm/boot/dts/rk3288-evb.dtsi | 2 +- arch/arm/boot/dts/rk3288-firefly.dtsi | 2 +- arch/arm/boot/dts/rk3288-popmetal.dts | 2 +- arch/arm/boot/dts/rk3288-r89.dts | 2 +- arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 2 +- arch/arm/boot/dts/rk3288-veyron.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3368-evb.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 2 +- 11 files changed, 11 insertions(+), 12 deletions(-) Hi Heiko, You can reviewed this, however there are couple of ARM64 dts additions. Also most of the other platform/SoC maintainers preferred to take it via their tree and few of these got missed during v4.5 merge window. Can you take it via your tree for v4.6 ?
I've split the patch in two, as the 32 and 64 bit devicetree parts go through separate branches and applied both to their respective branches for v4.6 Heiko