Re: [PATCH v2] ARM: dts: sun7i: Enable USB DRC on Itead Ibox

On 9 February 2016 at 19:34, Maxime Ripard [off-list ref]
wrote:

Hi,

On Tue, Feb 09, 2016 at 10:29:16AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:

quoted

From: Marcus Cooper <redacted>

Enable the otg/drc usb controller on the Itead Ibox device.

Note this board has the otg-vbus connected directly to the 5v-dcc of
the board, so there is no vbus0 regulator, nor vbus0-det.

Signed-off-by: Marcus Cooper <redacted>
---
Changes since v1:
- Added comment concerning vbus0 regulator and detection to commit

message

quoted

---
 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts     | 14 ++++++++++++++
 arch/arm/boot/dts/sunxi-itead-core-common.dtsi |  9 +++++++++
 2 files changed, 23 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts

b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts

quoted

index 661c21d..a512581 100644

--- a/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
+++ b/arch/arm/boot/dts/sun7i-a20-itead-ibox.dts

@@ -118,8 +118,22 @@
              allwinner,drive = <SUN4I_PINCTRL_20_MA>;
              allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
      };
+
+     usb0_id_detect_pin: usb0_id_detect_pin@0 {
+             allwinner,pins = "PH4";
+             allwinner,function = "gpio_in";
+             allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+             allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+     };
 };

 &reg_ahci_5v {
      status = "okay";
 };
+
+&usbphy {
+     pinctrl-names = "default";
+     pinctrl-0 = <&usb0_id_detect_pin>;
+     usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
+     status = "okay";
+};

diff --git a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi

b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi

quoted

index 2565d51..d22eea3 100644

--- a/arch/arm/boot/dts/sunxi-itead-core-common.dtsi
+++ b/arch/arm/boot/dts/sunxi-itead-core-common.dtsi

@@ -88,6 +88,10 @@
      status = "okay";
 };

+&otg_sram {
+     status = "okay";
+};
+
 #include "axp209.dtsi"

 &reg_dcdc2 {

@@ -129,6 +133,11 @@
      status = "okay";
 };

+&usb_otg {
+     dr_mode = "otg";

If VBUS is tied to 5V, without anyway to disable it, then it cannot do
OTG.

The mode it can do is host.

This is the same patch as what was applied to cubieboard2
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts/sun7i-a20-cubieboard2.dts?id=b8962f7ee700580a148e05eceb2302bcfc59ffbc
which it looks like this hardware copies. I can power the Ibox using this
USB socket and when I plug in a usb2ethernet device then it is detected.
BR,
CK

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.