Re: [PATCH 1/1] Drivers: USB: DA8xx MUSB: added DT support

On 02/08/2016 03:49 PM, Petr Kulhavy wrote:

quoted

   As for the mode and power, I agree -- they are part of the board-specific
platform data (there's also power-on-to-power-good delay BTW which you missed).

I've also noticed the potpgt it in the platform driver. However the musb
doesn't seem to use it, it's used by the ohci-da8xx driver.I will do.

    Indeed, it's not used and that probably should be fixed...

quoted

quoted

Why doesn't the musb core use directly the USB_DR_MODE_xxx literals
instead?

   MUSB driver predates these (DT specific?) definitions IIRC...

 >>

Would it make sense to replace it with the newer USB_DR_MODE_xxx ?

    Well, if you want to take on this task, ask Felipe, he's the maintainer...

Petr

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html