Alexandre,

On 02/19/2016 11:17 AM, Alexandre Belloni wrote:

Hi,

On 19/02/2016 at 11:09:45 -0700, Joshua Henderson wrote :

quoted

This driver adds support for the PIC32 real time clock and calendar
peripheral:
	- reading and setting time
	- alarms when connected to an IRQ

Just for confirmation, your probe() fails hard when there are no IRQ
specified or the IRQ request fails.

I'll review later but if that the only thing, I can fix it up when
applying, no need to resend.

probe() does indeed fail when no interrupt is specified:

  ...
  pic32-rtc 1f8c0000.rtc: no irq for alarm
  ...
  hctosys: unable to open rtc device (rtc0)
  ...

If I'm following, I think there right answer here is to just change the wording
in the commit message to be clear that the interrupt is not conditional.  It's
required via binding.  This peripheral has a dedicated interrupt and I can't
imagine a case where it makes sense not to specify it.

I'm fine with something like "- alarms provided by dedicated interrupt" as a
replacement.

Josh

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html