Re: [PATCH v4 1/3] mwifiex: register platform specific driver
From: Rob Herring <robh@kernel.org>
Date: 2016-02-18 14:38:14
Also in:
linux-bluetooth, lkml
On Tue, Feb 16, 2016 at 01:14:37AM -0800, Amitkumar Karwar wrote:
From: Xinming Hu <redacted>
Platform device and driver provides easy way to interact with
device-tree-enabled system.
This patch registers platform driver and reorganise existing device
tree specific code. Corresponding device tree binding file is also
created.
Signed-off-by: Xinming Hu <redacted>
Signed-off-by: Amitkumar Karwar <redacted>
---
v3: Don't update adapter->dt_node if mwifiex_plt_dev is NULL
v4: Corrected the 'name' and 'compatible' property names.(Arnd Bergmann and Rob
Herring)
Patch description wraped in 72 columns(Rob Herring)
Moved DT binding file to bindings/net/wireless/(Rob Herring)
---
.../bindings/net/wireless/marvell-sd8xxx.txt | 29 +++++++++++Again, one patch for all the binding changes.
quoted hunk ↗ jump to hunk
drivers/net/wireless/marvell/mwifiex/Makefile | 1 + drivers/net/wireless/marvell/mwifiex/main.c | 2 + drivers/net/wireless/marvell/mwifiex/main.h | 14 +++++ .../net/wireless/marvell/mwifiex/platform_drv.c | 59 ++++++++++++++++++++++ drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 4 +- 6 files changed, 107 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt create mode 100644 drivers/net/wireless/marvell/mwifiex/platform_drv.cdiff --git a/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt b/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt new file mode 100644 index 0000000..f7671ae --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt@@ -0,0 +1,29 @@ +Marvell Sd8xxx Wireless devices +------ + +Required properties: + + - name : must be "wlan" + - compatible : must be "marvell,sd8xxx"
No wildcards as Arnd mentioned.
+
+Optional properties:
+
+ - marvell,caldata* : A series of properties with marvell,caldata prefix,
+ represent Calibration data downloaded to the device during
+ initialization. This is an array of unsigned values.
+
+
+Example:
+
+Tx power limit calibration data is configured in below example.
+The calibration data is an array of unsigned values, the length
+can vary between hw versions.
+
+wlan {This also needs to be specified as a subnode of the SDIO controller.
+ compatible = "marvell,sd8xxx"; + + marvell,caldata_00_txpwrlimit_2g_cfg_set = /bits/ 8 < +0x01 0x00 0x06 0x00 0x08 0x02 0x89 0x01 ...>; + +}; +