Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

From
Wei Ni <hidden>
Date
2016-02-17 09:46:45
Also in
linux-tegra, lkml
Reply to
Wei Ni, 2016-02-15
Hi, Rob

On 2016年02月15日 15:15, Wei Ni wrote:
Hi, Rob

On 2016年02月12日 22:42, Rob Herring wrote:
quoted
On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni [off-list ref] wrote:
quoted
Add hw-trips sub-node for soctherm, which is
used to describe the hardware trip points for
each soctherm sensors.
I still don't understand why you are doing something custom here.
What's wrong with what is defined in:

Documentation/devicetree/bindings/thermal/thermal.txt
I think it's better to add a .set_trip_temp for of-thermal's
thermal_zone_of_device_ops{}, so that we can set trip points on hardware. I'm
preparing patches, and will send out next version.
Thanks for your comments.
In current thermal framework, it support to set trip points for the thermal
zones, but this trip point is handled by SW, doesn't have callbacks to program
the hardware.
There had patches:
[PATCH 12/16] thermal: thermal: Add support for hardware-tracked trip points,
http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000866.html,
which can support to program hardware to set trip points, but it seems this
series didn't be taken.
So I add this hw-trip-points sub-node for soctherm.

Hi, Sascha Hauer

Thanks.
Wei.
quoted
Rob
Thread (6 messages) 6 messages, 3 authors, last reply 2016-02-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help