Re: [PATCH 1/1 v2] MIPS: DTS: cavium-octeon: provide model attribute
From: David Daney <hidden>
Date: 2016-02-17 00:20:25
Also in:
linux-mips, lkml
On 02/15/2016 10:35 AM, Heinrich Schuchardt wrote:
Downstream packages like Debian flash-kernel rely on /proc/device-tree/model to determine how to install an updated kernel image. Most dts files provide this property. This patch adds a model attribute Octeon CPUs. v2: Use vendor prefix defined in vendor-prefixes.txt. Separate model from vendor by comma. Avoid wildcards. Cc: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Cc: Arnd Bergmann <redacted> Signed-off-by: Heinrich Schuchardt <redacted>
NAK. These device tree templates are only used on systems with archaic versions of u-boot. For all modern OCTEON systems, the device tree is provided by the firmware and is not under the control of the authors of the Linux kernel. Whatever problem you are attempting to solve, almost by definition, cannot be solved by modifying these files. We are worse off changing these, and giving people false hope that you are fixing something, than doing nothing. David Daney
quoted hunk ↗ jump to hunk
--- arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 + arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 + 2 files changed, 2 insertions(+)diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts index 9c48e05..f70cd58 100644 --- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts +++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts@@ -8,6 +8,7 @@ */ / { compatible = "cavium,octeon-3860"; + model = "cavium,Octeon 3860"; #address-cells = <2>; #size-cells = <2>; interrupt-parent = <&ciu>;diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts index 79b46fc..0b40899 100644 --- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts +++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts@@ -8,6 +8,7 @@ */ / { compatible = "cavium,octeon-6880"; + model = "cavium,Octeon 6880"; #address-cells = <2>; #size-cells = <2>; interrupt-parent = <&ciu2>;
-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html