Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT
From: Rob Herring <robh@kernel.org>
Date: 2016-02-12 15:20:20
Also in:
lkml, netdev
On Tue, Feb 09, 2016 at 09:01:12PM +0100, Bernhard Walle wrote:
quoted hunk ↗ jump to hunk
We need that for a custom hardware that needs the reverse reset sequence. Signed-off-by: Bernhard Walle <redacted> --- Changes compared to v1: - Add documentation to 'phy-reset-gpios' that flags are ignored as suggested by Andrew Lunn. Documentation/devicetree/bindings/net/fsl-fec.txt | 7 ++++++- drivers/net/ethernet/freescale/fec_main.c | 8 ++++++-- 2 files changed, 12 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt index a9eb611..0caa429 100644 --- a/Documentation/devicetree/bindings/net/fsl-fec.txt +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt@@ -7,11 +7,16 @@ Required properties: - phy-mode : See ethernet.txt file in the same directory Optional properties: -- phy-reset-gpios : Should specify the gpio for phy reset +- phy-reset-gpios : Should specify the gpio for phy reset. Additional + flags are ignored, see the non-standard 'phy-reset-active-low' property + instead. - phy-reset-duration : Reset duration in milliseconds. Should present only if property "phy-reset-gpios" is available. Missing the property will have the duration be 1 millisecond. Numbers greater than 1000 are invalid and 1 millisecond will be used instead. +- phy-reset-active-low : If present then the reset sequence using the GPIO + specified in the "phy-reset-gpios" property is reversed (H=reset state, + L=operation state).
This is what the gpio flags are for. Why can't you use that?
- phy-supply : regulator that powers the Ethernet PHY. - phy-handle : phandle to the PHY device connected to this device. - fixed-link : Assume a fixed link. See fixed-link.txt in the same directory.