Re: [PATCH V3 3/5] PCI: xilinx: Modifying AXI PCIe Host Bridge driver to work on both Zynq and Microblaze
From: Paul Burton <hidden>
Date: 2016-02-09 16:11:42
Also in:
linux-arm-kernel, linux-pci, lkml
On Tue, Feb 09, 2016 at 04:11:56PM +0530, Bharat Kumar Gogada wrote:
Modifying Xilinx AXI PCIe Host Bridge Soft IP driver to work on both Zynq and Microblaze Architectures. With these modifications drivers/pci/host/pcie-xilinx.c, will work on both Zynq and Microblaze Architectures. Signed-off-by: Bharat Kumar Gogada <redacted> Signed-off-by: Ravi Kiran Gummaluri <redacted> --- Changes: Removed unneccessary architecture dependent number of MSI's. Added #ifdef to pci_fixup_irqs which is ARM specific API.
Hi Bharat,
Why do you say pci_fixup_irqs is ARM-specific? It's declared in
include/linux/pci.h, defined in drivers/pci/setup-irq.c & used by
multiple architectures (alpha, arm, m68k, mips, sh, sparc, tile,
unicore32 from a quick grep).
Will you not break INTX-style interrupts by removing this?
Thanks,
Paul
quoted hunk ↗ jump to hunk
--- drivers/pci/host/pcie-xilinx.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c index 13fec35..6cbce34 100644 --- a/drivers/pci/host/pcie-xilinx.c +++ b/drivers/pci/host/pcie-xilinx.c@@ -704,7 +704,9 @@ static int xilinx_pcie_probe(struct platform_device *pdev) #endif pci_scan_child_bus(bus); pci_assign_unassigned_bus_resources(bus); +#ifdef CONFIG_ARM pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci); +#endif pci_bus_add_devices(bus); platform_set_drvdata(pdev, port);-- 2.1.1