Re: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port

I'm sorry, indeed, I was the one to overlook - there was a lot going
on in a thread and I missed it.

Ofer, as you found out that IRQF_SHARED help booting ubuntu - do you
think it's a hack or fix?

Best regards,
Marcin

2016-02-03 23:02 GMT+01:00 Thomas Petazzoni
[off-list ref]:

Dear Marcin Wojtas,

On Wed, 3 Feb 2016 22:41:15 +0100, Marcin Wojtas wrote:

quoted

Hi Gregory,

quoted

+       port->irq        = irq->start;
+       port->irqflags   = 0;

Same request as for v1, which you must have overlooked:
port->irqflags = IRQF_SHARED;

Gregory didn't overlook this comment you made on v1, he even replied to
it. Please check Gregory's reply to your review.

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com