Re: [PATCH 2/3] MIPS: dts: qca: ar9132: drop unused extosc mentions
From: Alban <hidden>
Date: 2016-01-21 10:52:18
Also in:
linux-mips
On Thu, 21 Jan 2016 12:59:04 +0300 Antony Pavlov [off-list ref] wrote:
At the moment ar913x_clocks_init() does not use extosc node at all,
the reference clock rate is hardcoded inside arch/mips/ath79/clock.c
#define AR913X_BASE_FREQ 5000000
...
static void __init ar913x_clocks_init(void)
{
ref_rate = AR913X_BASE_FREQ;
...
ath79_add_sys_clkdev("ref", ref_rate);
Also please see the commits 'MIPS: ath79: Fix the ar913x reference clock rate'
and 'MIPS: ath79: Fix the ar724x clock calculation' in Alban Bedel's
github ath79 branch https://github.com/AlbanBedel/linux/tree/ath79Yes, the reference clock definition is not yet used by the code, but the binding define it as required. This is because a proper implementation would need the reference clock rate. It would be better to fix the code to get rid of the hard coded rates when using DT. I haven't done so yet because I wanted to first get DT support without too many changes, but that's on the TODO list along with moving to drivers/clk. Alban -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html