Re: [PATCH 2/3] [v2] powerpc: fsl: update fman dt binding for PCS PHY
From: Rob Herring <robh@kernel.org>
Date: 2016-01-15 02:53:41
Also in:
linuxppc-dev, netdev
On Thu, Jan 14, 2016 at 04:27:18PM +0800, shh.xie@gmail.com wrote:
quoted hunk ↗ jump to hunk
From: Shaohui Xie <redacted> PCS PHY can support backplane (1000BASE-KX and 10GBASE-KR), this needs to change corresponding serdes lane settings, so a reference is needed for serdes lane. This patch describes properties needed for PCS PHY to support backplane. Signed-off-by: Shaohui Xie <redacted> --- changes in v2: addressed Rob's comments. based on http://patchwork.ozlabs.org/patch/560936/ Documentation/devicetree/bindings/powerpc/fsl/fman.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+)diff --git a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt index 55c2c03..5ca909a 100644 --- a/Documentation/devicetree/bindings/powerpc/fsl/fman.txt +++ b/Documentation/devicetree/bindings/powerpc/fsl/fman.txt@@ -432,6 +432,16 @@ example of how to define a PHY (Internal PHY has no interrupt line). - For "fsl,fman-mdio" compatible internal mdio bus, the PHY is TBI PHY. - For "fsl,fman-memac-mdio" compatible internal mdio bus, the PHY is PCS PHY, PCS PHY addr must be '0'. + PCS PHY can support backplane (1000BASE-KX and 10GBASE-KR), this needs to + change the corresponding serdes lane settings. + + PCS PHY node properties required for backplane: + + - compatible: must be "ethernet-phy-ieee802.3-c45". + - phy-mode: string, operation mode of the PHY interface; must be "1000base-kx" + for 1000BASE-KX, or "10gbase-kr" for 10GBASE-KR. + - fsl-lane-handle: phandle, specifies a reference to a node representing a Serdes. + - fsl-lane-reg: offset and length of the register set for the serdes lane.
These should be fsl,... not fsl-... Rob