Re: [PATCH V4 07/11] of: Add bindings of hw-trip-points for soctherm
From: Rob Herring <hidden>
Date: 2016-01-26 02:42:07
Also in:
linux-tegra, lkml
On Mon, Jan 25, 2016 at 06:46:36PM +0800, Wei Ni wrote:
Add hw-trips sub-node for soctherm, which is used to describe the hardware trip points for each soctherm sensors.
This seems like something that should be common. There was a hwmon binding just the other day with temperature set points.
quoted hunk ↗ jump to hunk
Signed-off-by: Wei Ni <redacted> --- .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+)diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt index 6b68cd150405..75dc9dbe7e1a 100644 --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt@@ -26,6 +26,15 @@ Required properties : of this property. See <dt-bindings/thermal/tegra124-soctherm.h> for a list of valid values when referring to thermal sensors. +Optional properties: +- hw-trip-points : A sub-node which is a container of hardware trip points + for each sensors. + * sensors: Sub-nodes which are used to describe the HW trip points info, + must be named as "cpu", "gpu", "mem", "pll". + Properties: + - thermtrip-temperature : Shutdown or reset temperature in millicelsius, + once the temperature of this sensor is higher than the + thermtrip-temperature, the system will be shutdown or reset.
Append units and temperature is a bit redundant. Something like thermtrip-mC or thermtrip-milliC You could easily have multiple levels of trip points, so perhaps the name needs to reflect the action (i.e. shutdown). Rob