RE: [PATCH v5 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

Hi Peter,

-----Original Message-----
From: Peter Korsgaard [mailto:jacmet@gmail.com] On Behalf Of Peter Korsgaard
Sent: 2016年1月15日 15:58
To: Yang, Wenyou <redacted>
Cc: Lee Jones <redacted>; Rob Herring <robh+dt@kernel.org>;
Pawel Moll [off-list ref]; Mark Rutland [off-list ref]; Ian
Campbell [off-list ref]; Kumar Gala [off-list ref];
devicetree@vger.kernel.org; Krzysztof Kozlowski [off-list ref];
Ferre, Nicolas [off-list ref]; linux-kernel@vger.kernel.org;
Javier Martinez Canillas [off-list ref]; linux-arm-
kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC
MFD driver

quoted

quoted

quoted

quoted

quoted

"Yang," == Yang, Wenyou [off-list ref] writes:

Hi,

 >> Why not make it a tristate instead? Having regulators as modules is perhaps
not a  >> very wise thing to do, but conceptually I don't see why this code couldn't
be a  >> module.

 > Yes, you are right. it can be use a tristate.

Ok, good.

quoted

quoted

quoted

+	act8945a = devm_kzalloc(&i2c->dev, sizeof(*act8945a),
+GFP_KERNEL);

 >> > +	if (!act8945a)
 >> > +		return -ENOMEM;
 >> > +
 >>
 >> What is the point of this structure (and the header file)? Can't the subdevices
just  >> do dev_get_regmap(dev->parent)? regulator_register() afaik already does
this by  >> default.

 > Yes, I re-read regulator_register() code. It did do dev_get_regmap(dev-

quoted

parent).

 > I think this structure should be pointed by dev->parent, this structure is
necessary.

 > Yes regulator driver should be simpler.

 > Moreover, it is used by another sub device, charger. Which don't such code.

But the charger driver can just as well do:

dev_get_regmap(dev->parent);

instead of:

dev_get_drvdata(pdev->dev.parent)->regmap.

Understand. 

Thank you!


Best Regards,
Wenyou Yang
N�Р骒r��y����b�X�肚�v�^�)藓{.n�+���z��z谵z)��骅w*jg�报
�����茛j.镗�\浇M��gj替a����' �┺⒏
⒎�j:+v���w�j�m������赙zZ+�����茛j"��!�i