Re: [PATCH] rtc: max77xxx: fix of_table.cocci warnings
From: Laxman Dewangan <ldewangan@nvidia.com>
Date: 2016-01-12 11:31:20
Also in:
linux-gpio, linux-rtc, lkml
Hi Julia, Thanks for pointing this issue. What script do you run to get this error? I tried to run script/coccicheck and it did not showed this issue. When I run make with coccicheck per Documentation, it did not show specific to this error. Although, there was lots of output. I want to get this type of error by running script. Any command for this? Thanks, Laxman On Tuesday 12 January 2016 04:57 PM, Julia Lawall wrote:
quoted hunk ↗ jump to hunk
Make sure (of/i2c/platform)_device_id tables are NULL terminated Generated by: scripts/coccinelle/misc/of_table.cocci CC: Laxman Dewangan <ldewangan@nvidia.com> Signed-off-by: Fengguang Wu <redacted> Signed-off-by: Julia Lawall <redacted> --- Please take the patch only if it's a positive warning. Thanks! rtc-max77xxx.c | 1 + 1 file changed, 1 insertion(+)--- a/drivers/rtc/rtc-max77xxx.c +++ b/drivers/rtc/rtc-max77xxx.c@@ -480,6 +480,7 @@ static const struct platform_device_id m { .name = "max77xxx-rtc", }, { .name = "max77620-rtc", }, { .name = "max20024-rtc", }, + {}, }; static struct platform_driver max77xxx_rtc_driver = {