RE: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

Hi Rob,

-----Original Message-----
From: Rob Herring [mailto:robh@kernel.org]
Sent: 2016年1月9日 23:38
To: Yang, Wenyou <redacted>
Cc: Lee Jones <redacted>; Pawel Moll <redacted>; Mark
Rutland [off-list ref]; Ian Campbell [off-list ref];
Kumar Gala [off-list ref]; Ferre, Nicolas
[off-list ref]; linux-kernel@vger.kernel.org;
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

On Fri, Jan 08, 2016 at 10:05:28AM +0800, Wenyou Yang wrote:

quoted

The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two
subdevices:
 - Regulator
 - Charger

This patch adds documentation for ACT8945A DT bindings.

Signed-off-by: Wenyou Yang <redacted>

One nit, otherwise:

Acked-by: Rob Herring <robh@kernel.org>

quoted

---

 Documentation/devicetree/bindings/mfd/act8945a.txt |   16

++++++++++++++++

quoted

 1 file changed, 16 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt

diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt

b/Documentation/devicetree/bindings/mfd/act8945a.txt
new file mode 100644
index 0000000..406db16

--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/act8945a.txt

@@ -0,0 +1,16 @@
+Device-Tree bindings for Active-semi ACT8945A MFD driver
+
+Required properties:
+ - compatible: "active-semi,act8945a".
+ - reg: the I2C slave address for the ACT8945A chip
+
+The chip exposes two subdevices:
+ - a regulators: see ../regulator/act8945a-regulator.txt
+ - a charger: see ../power/act8945a-charger.txt
+
+Example:
+	mfd: act8945a@5b {

s/act8945a/pmic/

The patch is changed in the next verion, add the pmic and charger nodes.

So, I am not add your Acked-by.

quoted

+		compatible = "active-semi,act8945a";
+		reg = <0x5b>;
+		status = "okay";
+	};
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree"
in the body of a message to majordomo@vger.kernel.org More majordomo
info at  http://vger.kernel.org/majordomo-info.html

Best Regards,
Wenyou Yang
N�Р骒r��y����b�X�肚�v�^�)藓{.n�+���z��z谵z)��骅w*jg�报
�����茛j.镗�\浇M��gj替a����' �┺⒏
⒎�j:+v���w�j�m������赙zZ+�����茛j"��!�i