Re: [rtc-linux] [PATCH 2/6] mfd: max77620: add core driver for MAX77620/MAX20024
From: Lee Jones <hidden>
Date: 2016-01-11 09:05:14
Also in:
linux-gpio, linux-rtc, lkml
On Mon, 11 Jan 2016, Krzysztof Kozlowski wrote:
On 11.01.2016 14:46, Lee Jones wrote:quoted
On Fri, 08 Jan 2016, Krzysztof Kozlowski wrote: Thanks for taking the time to review.quoted
()2016-01-07 23:38 GMT+09:00 Laxman Dewangan [off-list ref]:quoted
MAX77620/MAX20024 are Power Management IC from the MAXIM. It supports RTC, multiple GPIOs, multiple DCDC and LDOs, watchdog, clock etc. Add MFD drier to provides common support for accessing the device; additional drivers is developed on respected subsystem in order to use the functionality of the device. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> Signed-off-by: Chaitanya Bandi <redacted> Signed-off-by: Mallikarjun Kasoju <redacted> Tested-by: Venkat Reddy Talla <redacted>The Testing and Reviewed are statements (see SubmittingPatches) so they should be made explicitly by people. As this is v1 how they could make a public statement so far?SubmittingPatches bears no mention that Reviewed-by/Tested-by statements have to be provided on one of the public mailing lists. These can be provided privately prior to upstream submission v1.Indeed the document does not mention that they have to be provided by public. In the same time these are statements given by a reviewer ("By offering my Reviewed-by: tag, I state that:")... and how can you validate a statement given through a private channel? Is it true? Is it a thorough testing or just copy-paste from Gerrit (or other automated system)?
That is for the submitter's conscience to decide. If the statements are supplied, we must assume they were provided in good faith and in accordance with the rules set out by the Linux Kernel. We can not ask for every Tested-by/Acked-by/Reviewed-by/etc provider to verify on each upstream submission. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog