Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2

Stefan Wahren [off-list ref] writes:

quoted

Måns Rullgård [off-list ref] hat am 10. Januar 2016 um 14:42 geschrieben:


Stefan Wahren [off-list ref] writes:

quoted

quoted

Måns Rullgård [off-list ref] hat am 10. Januar 2016 um 14:13 geschrieben:


Stefan Wahren [off-list ref] writes:

quoted

Hi Mans,

quoted

Mans Rullgard [off-list ref] hat am 10. Januar 2016 um 13:40
geschrieben:


Add pinmux setting for USB1 overcurrent on pwm2 pad.

could you please change your patch to describe why you need to add
this pinmux?

I'm working on a board that is wired that way. I can of course put this
in the board-specific dts if that's preferable.

So the board isn't submitted to mainline?

Not yet anyway.

quoted

IMHO the change is okay, but the description doesn't explain why is it
needed.

So a suitable description would be that it's needed for board xy.

Would it be better to send this patch in a series along with the full
board support?

Yes, it would be nice to have a dts file which reference the new pinmux.

OK, I'll sit on it for a while longer then.

-- 
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html