Thread (42 messages) 42 messages, 6 authors, 2016-02-05

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

From: Paul Kocialkowski <hidden>
Date: 2016-01-03 10:19:46
Also in: linux-arm-kernel, linux-omap, lkml

Le jeudi 31 décembre 2015 à 22:14 +0000, Mark Brown a écrit :
On Thu, Dec 31, 2015 at 10:59:06PM +0100, Paul Kocialkowski wrote:
quoted
I understand, thanks for pointing this out. Well, for my use case, there
is no use in disabling the chip at any point as it powers the external
mmc.
Presumably someone might decide not to use the MMC in some case (perhaps
only mounting it when explicitly needed in order to save power for
example, or the MMC subsystem might figure out a way to power down an
idle MMC block device).
Makes sense, I'll keep that in mind.
quoted
Would you agree to have the enable pin handled directly (and by that, I
mean enabled once, when requested, as I first suggested in the patchset)
in the driver then?
That's probably fine, or do it via runtime PM (the framework is fairly
simple to use, I'll probably go add support in the core for it in the
next day or two as this seems like a sensible use case).  I can't
remember if this device is a MFD or not and I'm just on my way out the
door.
Runtime PM seems like a good fit (though I hadn't heard about it before:
you can guess I'm fairly new to kernel development), please let me know
whether you end up implementing it so I can try to handle the GPIO this
way.

Thanks!

-- 
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: https://www.replicant.us/
Blog: https://blog.replicant.us/
Wiki/tracker/forums: https://redmine.replicant.us/

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help