Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

Hi Richard,
 
 On mer., déc. 16 2015, Richard Cochran [off-list ref] wrote:

On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote:

quoted

+Optional properties for PHY child node:
+- reset-gpios : Should specify the gpio for phy reset

reset-gpios plural or reset-gpio singular?

The bindings name is plural but it handle only one gpio.

See:
https://lkml.org/lkml/2015/12/9/623

quoted

+
 Examples:
 
 	macb0: ethernet@fffc4000 {

@@ -29,4 +32,8 @@ Examples:
 		local-mac-address = [3a 0e 03 04 05 06];
 		clock-names = "pclk", "hclk", "tx_clk";
 		clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>;
+		ethernet-phy@1 {
+			reg = <0x1>;
+			reset-gpios = <&pioE 6 1>;

Did you mean "gpioE" ?

No, I really mean pioE: it is the name used for the at91 SoCs.

Thanks,

Gregory

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com