On Mon, 2015-12-14 at 19:19 +0100, Matthias Brugger wrote:

On 08/12/15 10:49, Yong Wu wrote:

quoted

This patch adds support for mediatek m4u (MultiMedia Memory Management
Unit).

Signed-off-by: Yong Wu <yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---

[...]

quoted

+static void mtk_iommu_config(struct mtk_iommu_data *data,
+			     struct device *dev, bool enable)
+{
+	struct mtk_iommu_client_priv *head, *cur, *next;
+
+	head = dev->archdata.iommu;
+	list_for_each_entry_safe(cur, next, &head->client, client) {
+		mtk_smi_config_port(
+			data->larbdev[MTK_M4U_TO_LARB(cur->mtk_m4u_id)],
+			MTK_M4U_TO_PORT(cur->mtk_m4u_id), enable);

Use an extra variable for MTK_M4U_TO_LARB(cur->mtk-m4u_id), this makes 
the code easier to read.

OK. Thanks.
I will fix it in next version.

Regards,
Matthias

quoted

+	}
+}
+

[...]