Thread (28 messages) 28 messages, 7 authors, 2015-12-14

Re: [RFC][PATCH] misc: Introduce reboot_reason driver

From: John Stultz <hidden>
Date: 2015-12-09 21:42:19
Also in: lkml

On Wed, Dec 9, 2015 at 12:50 AM, Sascha Hauer [off-list ref] wrote:
On Tue, Dec 08, 2015 at 04:13:35PM -0800, John Stultz wrote:
quoted
Is there a better way? Are enums for array indexes out of fashion?
They are not, but you have declared a variable (reason_types) which you
don't use. You probably meant to create a enum named reason_types, like
this:

enum reason_types {
        NONE,
        BOOTLOADER,
        RECOVERY,
        OEM,
        MAX_REASONS
};
So I had tried using a enum name as well, close to what you suggest
here, and still got the "warning: useless storage class specifier in
empty declaration" build warning.

Though trying again, it seems the problem was I was declaring it as
"static enum ...". Removing the static allows it to build w/o warnings
as a unnamed enum structure.  Why, I don't know. :P

Thanks for the pointer!
-john
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help