Hi,

Thank you for the review!

From: Kishon Vijay Abraham I [mailto:kishon@ti.com]
Sent: Friday, November 27, 2015 2:21 PM

Hi,

On Tuesday 20 October 2015 02:27 PM, Yoshihiro Shimoda wrote:

quoted

This patch adds support for R-Car generation 3 USB2 PHY driver.
This SoC has 3 EHCI/OHCI channels, and the channel 0 is shared
with the HSUSB (USB2.0 peripheral) device. And each channel has
independent registers about the PHYs.

So, the purpose of this driver is:
 1) initializes some registers of SoC specific to use the
    {ehci,ohci}-platform driver.

 2) detects id pin to select host or peripheral on the channel 0.

For now, this driver only supports 1) above.

When you do 2), make sure to use the extcon framework.

Thank you for your proposal! I will use the extcon framework for it.

One minor comment below and then I can queue it for 4.5.

Thank you!

< snip >

quoted

+	provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
+	if (IS_ERR(provider)) {
+		dev_err(dev, "Failed to register PHY provider\n");
+		return PTR_ERR(provider);
+	}
+
+	return 0;

This can simply be replaced with return PTR_ERR_OR_ZERO(provider);

Yes, I tested that this could simply be replaced with "return PTR_ERR_OR_ZERO(provider);".
So, should I send v6 patch?

Best regards,
Yoshihiro Shimoda

Thanks
Kishon