Thread (42 messages) 42 messages, 4 authors, 2015-10-13

Re: [PATCH v2 3/9] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file

From: Peter Griffin <peter.griffin@linaro.org>
Date: 2015-10-13 10:41:39 

Hi,

On 8 October 2015 at 16:43, Koul, Vinod [off-list ref] wrote:

On Fri, 2015-09-11 at 15:14 +0100, Peter Griffin wrote:
quoted
+#define FDMA_ID_OFST         0x00000
+#define FDMA_VER_OFST                0x00004
quoted
+
+#define FDMA_EN_OFST         0x00008
Why cant these be BIT() to maintain consistency?
These are actually register offsets. I'm only using the BIT
macro for bitfields within the registers e.g. FDMA_EN_RUN

regards,

Peter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help