Thread (15 messages) 15 messages, 2 authors, 2015-10-16

Re: [PATCH v9 3/6] pci:host: Add Altera PCIe host controller driver

From: Ley Foon Tan <hidden>
Date: 2015-10-14 08:32:32
Also in: linux-arm-kernel, linux-pci, lkml

On Wed, Oct 14, 2015 at 4:20 PM, Arnd Bergmann [off-list ref] wrote:
On Wednesday 14 October 2015 10:41:29 Ley Foon Tan wrote:
quoted
+static int altera_pcie_remove(struct platform_device *pdev)
+{
+     struct altera_pcie *pcie = platform_get_drvdata(pdev);
+
+     altera_pcie_free_irq_domain(pcie);
+     platform_set_drvdata(pdev, NULL);
+     return 0;
+}
I just noticed this. Does it actually work to unload the module
and tear down all the pci_dev structures in a safe way?
Good catch. It only can be compiled as builtin-moduley now, so we can
remove this _remove callback function.
Thanks.

Regards
Ley Foon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help