Re: [PATCH 05/10] clk: iproc: Add PLL base write function
From: Stephen Boyd <hidden>
Date: 2015-10-10 00:21:11
Also in:
linux-arm-kernel, linux-clk, lkml
On 10/02, Jon Mason wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/bcm/clk-iproc-pll.c b/drivers/clk/bcm/clk-iproc-pll.c index e029ab3..a4602aa 100644 --- a/drivers/clk/bcm/clk-iproc-pll.c +++ b/drivers/clk/bcm/clk-iproc-pll.c@@ -137,6 +137,18 @@ static int pll_wait_for_lock(struct iproc_pll *pll) return -EIO; } +static void iproc_pll_write(struct iproc_pll *pll, void __iomem *base, + u32 offset, u32 val) +{ + const struct iproc_pll_ctrl *ctrl = pll->ctrl; + + writel(val, base + offset); + + if (unlikely(ctrl->flags & IPROC_CLK_NEEDS_READ_BACK && + base == pll->pll_base)) + val = readl(base + offset);
Is there any point to assign val here? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project