Thread (7 messages) 7 messages, 3 authors, 2015-10-01

RE: [PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Date: 2015-10-01 10:01:37
Also in: linux-sh, lkml

Hi Rob,
Sent: Friday, September 25, 2015 9:42 PM

Hi Rob,

Thank you for your comment!
And, I'm sorry for the delayed response.
quoted
Sent: Monday, September 21, 2015 11:01 PM

On 09/18/2015 01:08 AM, Kishon Vijay Abraham I wrote:
< snip >
quoted
quoted
quoted
+Example (R-Car H3):
+
+	usb-phy@ee080200 {
+		compatible = "renesas,usb2-phy-r8a7795";
+		reg = <0 0xee080200 0 0x6ff>, <0 0xe6590100 0 0x100>;
+		reg-names = "usb2", "hsusb";
hsusb is missing in Documentation.
usb2 is the host controller? It is questionable that these should be
combined. Does this appear under another node? If so, don't overlap
resources in the DT.
Thank you for the point.
I don't think that this appears under another node.
However, to avoid such a situation, I should change the name somehow.
Perhaps I misunderstood your point. So, let me comment below again:

- This "usb2" means the partial registers of USB 2.0 host block.
  That host registers can control the USB2.0 PHY.
  This "hsusb" means the partial registers of USB 2.0 peripheral block.
  That peripheral registers can control the selector (host or peripheral).
  So, these should be combined in this driver.

- These resources don't appear under another nodes.

Best regards,
Yoshihiro Shimoda
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help