RE: [PATCH] usb: renesas_usbhs: Add support for R-Car H3

Hi Morimoto-san,

Thank you for the comment.
And, I'm sorry for the delayed response.

Sent: Friday, September 18, 2015 5:25 PM

Hi Shimoda-san

quoted

This patch adds a compatible string to support for R-Car H3.

Since the HS-USB controller of R-Car H3 is almost the same specification
with R-Car Gen2 (these have 16 pipes and usb-dmac), this patch
sets the "type" of renesas_usbhs_driver_param to USBHS_TYPE_RCAR_GEN2.

Signed-off-by: Yoshihiro Shimoda <redacted>
---

(snip)

quoted

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 7b98e1d..2becd6b 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c

@@ -476,6 +476,10 @@ static const struct of_device_id usbhs_of_match[] = {
 		.compatible = "renesas,usbhs-r8a7794",
 		.data = (void *)USBHS_TYPE_RCAR_GEN2,
 	},
+	{
+		.compatible = "renesas,usbhs-r8a7795",
+		.data = (void *)USBHS_TYPE_RCAR_GEN2,
+	},

It is helpful for user if it is indicating Gen2 compatible.
Because r8a7795 is Gen3

So, I will add a comment in the code like the followings:

{
	/* Gen3 is compatible with Gen2 */
	.compatible = "renesas,usbhs-r8a7795",
	.data = (void *)USBHS_TYPE_RCAR_GEN2,
},

Best regards,
Yoshihiro Shimoda

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html